Load and save video-processor from separate folder#33562
Merged
zucchini-nlp merged 2 commits intohuggingface:mainfrom Sep 19, 2024
Merged
Load and save video-processor from separate folder#33562zucchini-nlp merged 2 commits intohuggingface:mainfrom
zucchini-nlp merged 2 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Sep 18, 2024
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding this patch!
src/transformers/models/llava_onevision/processing_llava_onevision.py
Outdated
Show resolved
Hide resolved
…sion.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Member
Author
|
Will update files in the hub soon, merging for now. Loading with old format works anyway |
Member
Author
|
Done! Updated and tested by loading back |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* load and save from video-processor folder * Update src/transformers/models/llava_onevision/processing_llava_onevision.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> --------- Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #33484.
One thing to note is that we are forced to save in a separate folder, not a json file with
video_prefix. I see a workaround here by acceptingsave_filenamewhen saving image processorr, but seems quite against the general idea of saving/loading in transformers. So I guess we can leave it as separate folder and for this model only we'll maintain folder loading for a while, even after new video processor class is adddedcc @yonigozlan